Bound pip < 19.2 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vansivallab What is motivating this limit? |
jacindaz
approved these changes
Aug 22, 2019
aclowes
reviewed
Aug 23, 2019
There was a problem hiding this comment.
I think you want to do this in clinical-data-service or temple-django-grpc instead? ie here: https://github.com/CloverHealth/clinical-data-service/blob/91f43f5e07995f294aba2a342dc8609614bd8881/Makefile#L106
Also, add a comment so people know how to reproduce the issue (ie work around error "unexpected keyword argument 'find_links'" when running make compile_dependencies).
|
@aclowes good point, pinning pip is only needed if we compile requirements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are having issues compiling requirements in clinical-data-service this is due to an issue with pip. The temporary solution seems to be to pin pip below 19.2.