Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shouldn't MinDaysOld be MaxDaysOld? #76

Closed
laur89 opened this issue Feb 11, 2025 · 2 comments
Closed

shouldn't MinDaysOld be MaxDaysOld? #76

laur89 opened this issue Feb 11, 2025 · 2 comments
Labels
question Further information is requested

Comments

@laur89
Copy link

laur89 commented Feb 11, 2025

As readme states:

...Packages must contain an app which was released on Steam within the last MinDaysOld days or they will not be added

This sounds more like max days, not min.

Say we have configured it to value of 3. That means if title was released 4 days ago, it won't get added. However the condition sounds as if it's met, as this title is at least (or, "minimum") three days old.

This leaves me to believe the config name should be called MaxDaysOld instead.

@laur89 laur89 added the question Further information is requested label Feb 11, 2025
@woctezuma
Copy link

woctezuma commented Feb 11, 2025

The parameter was added after a question about MinReviewScore, hence the similar name. See:

As for the logic, you may be correct indeed.

@Citrinate
Copy link
Owner

Yeah that's right, it should be Max. I'll fix this for the next release, but keep MinDaysOld as an undocumented alias for MaxDaysOld as to not break anyone's configs.

Citrinate added a commit that referenced this issue Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants