Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic updates causing nested folders #72

Closed
PacFox opened this issue Jan 6, 2025 · 4 comments
Closed

Automatic updates causing nested folders #72

PacFox opened this issue Jan 6, 2025 · 4 comments

Comments

@PacFox
Copy link

PacFox commented Jan 6, 2025

I have automatic updates of the plugin enabled through the global ASF setting however I noticed after several updates the folder structure has now become plugins/FreePackages/FreePackages/FreePackages/FreePackages/FreePackages/FreePackages/. My guess this is caused due to the plugin being zipped in a FreePackages root folder and the updater extracts the folder structure as is. Checking the official plugin ArchiSteamFarm.OfficialPlugins.Monitoring zip file it doesn't seem to use a root folder just having the plugin files right away.

@woctezuma
Copy link

woctezuma commented Jan 6, 2025

Do you also have ASFEnhance?

Related:

@PacFox
Copy link
Author

PacFox commented Jan 6, 2025

Do you also have ASFEnhance?

Related:

* [Updating the plugin messes other plugins chr233/ASFEnhance#342](https://github.com/chr233/ASFEnhance/issues/342)

Nope, my only custom plugin is FreePackages which I had initially extracted in it's own FreePackages folder in my plugins folder.

@JustArchi
Copy link

JustArchi commented Jan 7, 2025

This is because FreePackages.zip provided has FreePackages directory inside.

https://github.com/JustArchiNET/ArchiSteamFarm/wiki/Plugins-development#igithubpluginupdates

Each tag should have appropriate release available on GitHub with zip file release asset that includes your plugin binary files. The binary files that include your IPlugin classes should be available in the root directory within the zip file.

This is something @Citrinate can fix easily without causing any breaking changes, merely updating zip structure.

Citrinate added a commit that referenced this issue Jan 7, 2025
@Citrinate
Copy link
Owner

Removed the FreePackages folder inside the zip, shouldn't have this problem anymore. During initial install of the plugin you should still make sure that all of the plugin files exist within their own FreePackages folder (or whatever you care to name it).

Related:

I also experienced this behavior when testing if the plugin dll is located directly in the plugins folder. Everything works correctly if the plugin files are instead placed in their own separate folders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants