Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setChoices regression in v11.0.4, where replaceChoices argument would deselect selected items. Fixes #1278 #1279

Merged
merged 6 commits into from
Feb 26, 2025
Merged

Fix setChoices regression in v11.0.4, where replaceChoices argument would deselect selected items. Fixes #1278 #1279

merged 6 commits into from
Feb 26, 2025

Conversation

Xon
Copy link
Collaborator

@Xon Xon commented Feb 26, 2025

  • Do not clear selected items by default
  • Move clearChoices call into the withTnx call to avoid multiple rendering passes when the state isn't atomically updated
  • Update setChoices documentation

@Xon Xon added the bugfix Pull request that fixes an existing bug label Feb 26, 2025
@Xon Xon changed the title Fix setChoices regression #1278 Fix setChoices regression, fixes #1278 Feb 26, 2025
@Xon Xon linked an issue Feb 26, 2025 that may be closed by this pull request
11.0.4 - setChoices when replaceChoices is true, the default selected is cleared #1278
Closed
@Xon Xon merged commit e0bb294 into main Feb 26, 2025
11 checks passed
@Xon Xon deleted the fix-setChoices branch February 26, 2025 13:05
@Xon Xon changed the title Fix setChoices regression, fixes #1278 Fix setChoices regression, where replaceChoices argument would deselect selected items. Fixes #1278 Feb 26, 2025
@Xon Xon changed the title Fix setChoices regression, where replaceChoices argument would deselect selected items. Fixes #1278 Fix setChoices regression in v11.0.4, where replaceChoices argument would deselect selected items. Fixes #1278 Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix Pull request that fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

11.0.4 - setChoices when replaceChoices is true, the default selected is cleared
1 participant
@Xon