fix: report job count only after it was persisted #593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CheckerNetwork/node#583 (hopefully).
This change has a side effect when running a high-job-frequency module like the former Saturn L2 node or Voyager:
Before, we would update the state file every time a job was completed.
Now, we update the state file at most once per 200ms, as configured via
job_report_delay
:https://github.com/filecoin-station/zinnia/blob/9d882e48e5b9f0fdab2530fdc08c69987a4237a6/daemon/main.rs#L78-L82
I am arguing this is a change for the better because there is no point in hammering the file system (and SSD drives) with too frequent updates of the state file.