Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prevent showing 0's on resumed thread if AskAction/File was used #1840

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

lamylio
Copy link
Contributor

@lamylio lamylio commented Jan 31, 2025

Hello, the redesign of Chainlit on V2 introduced back an issue (#1548) where the assistant messages would display "0" in some case when thread contains a AskActionMessage or AskFileMessage element.

This simply applies back the same fix as the PR #1617 to change the logic on the frontend.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. frontend Pertains to the frontend. labels Jan 31, 2025
Copy link
Collaborator

@willydouhard willydouhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@willydouhard willydouhard added this pull request to the merge queue Feb 1, 2025
Merged via the queue into Chainlit:main with commit 34b2bb6 Feb 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Pertains to the frontend. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants