Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use bigint gwei type for amount in requests instead of num 64 #7085

Merged
merged 3 commits into from
Sep 14, 2024
Merged

fix: use bigint gwei type for amount in requests instead of num 64 #7085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3669d75
fix: use bigint gwei type for amount in requests instead of num 64
g11tech Sep 14, 2024
fe6f0c9
revert deposit amount to uintnum64 as unlikely to get a high amount
g11tech Sep 14, 2024
75aef56
fix
g11tech Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/beacon-node/src/execution/engine/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ export function deserializeWithdrawalRequest(withdrawalRequest: WithdrawalReques
return {
sourceAddress: dataToBytes(withdrawalRequest.sourceAddress, 20),
validatorPubkey: dataToBytes(withdrawalRequest.validatorPubkey, 48),
amount: quantityToNum(withdrawalRequest.amount),
amount: quantityToBigint(withdrawalRequest.amount),
};
}

Expand Down
4 changes: 3 additions & 1 deletion packages/types/src/electra/sszTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ export const DepositRequest = new ContainerType(
{
pubkey: BLSPubkey,
withdrawalCredentials: Bytes32,
// this is actually gwei uintbn64 type, but super unlikely to get a high amount here
// to warrant a bn type
amount: UintNum64,
signature: BLSSignature,
index: DepositIndex,
Expand All @@ -129,7 +131,7 @@ export const WithdrawalRequest = new ContainerType(
{
sourceAddress: ExecutionAddress,
validatorPubkey: BLSPubkey,
amount: UintNum64,
amount: Gwei,
},
{typeName: "WithdrawalRequest", jsonCase: "eth2"}
);
Expand Down
Loading