Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: update hashing libs to noble #323

Merged
merged 4 commits into from
May 8, 2023
Merged

fix!: update hashing libs to noble #323

merged 4 commits into from
May 8, 2023

Conversation

mpetrunic
Copy link
Member

@mpetrunic mpetrunic commented Apr 27, 2023

related to #321

BEGIN_COMMIT_OVERRIDE
fix!: update hashing libs to noble, stablelib crypto backend renamed to pureJsCrypto
BREAKING CHANGE: stablelib crypto backend renamed to pureJsCrypto
END_COMMIT_OVERRIDE

@mpetrunic mpetrunic marked this pull request as ready for review April 27, 2023 08:53
@mpetrunic mpetrunic requested a review from a team as a code owner April 27, 2023 08:53
twoeths
twoeths previously approved these changes May 4, 2023
@dapplion
Copy link
Contributor

dapplion commented May 4, 2023

@tuyennhv do we have a plan to keep using the fastest crypto backend available in Lodestar?

mpetrunic added 2 commits May 5, 2023 11:49
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
@mpetrunic mpetrunic force-pushed the update-hashing-libs branch from 68b92ff to 9161ad9 Compare May 5, 2023 09:49
mpetrunic added 2 commits May 5, 2023 12:00
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
@mpetrunic mpetrunic changed the title fix: update hashing libs to @noble fix!: update hashing libs to @noble May 5, 2023
@wemeetagain
Copy link
Member

we have a plan

There's no code change necessary in lodestar

@mpetrunic mpetrunic merged commit 3732fda into master May 8, 2023
@mpetrunic mpetrunic deleted the update-hashing-libs branch May 8, 2023 07:52
@mpetrunic mpetrunic changed the title fix!: update hashing libs to @noble fix!: update hashing libs to noble May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants