feat: unbundle fixed-label metrics #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
reviewed
Aug 7, 2023
| break | ||
| default: | ||
| this.meshPeerInclusionEventsUnknown.inc({ topic }, count) | ||
| break |
There was a problem hiding this comment.
Is it really necessary to have so much granularity here?
There was a problem hiding this comment.
@dapplion without it we don't know how mesh peers are added for beacon_attestation topic like before
maybe it's not important for this specific metric, but the same granularity for ChurnReason metrics below are quite important when investigating low mesh peer issue
so it's more code here but beneficial for the applications using gossipsub
dapplion
approved these changes
Aug 8, 2023
wemeetagain
approved these changes
Aug 10, 2023
wemeetagain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See Broken IGNORE/REJECT metrics lodestar#5853
Description