Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch errored push of rpc #334

Merged
merged 1 commit into from
Aug 24, 2022
Merged

fix: catch errored push of rpc #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2111,7 +2111,21 @@ export class GossipSub extends EventEmitter<GossipsubEvents> implements Initiali
}

const rpcBytes = RPC.encode(rpc).finish()
outboundStream.push(rpcBytes)
try {
outboundStream.push(rpcBytes)
} catch (e) {
this.log.error(`Cannot send rpc to ${id}`, e)

// if the peer had control messages or gossip, re-attach
if (ctrl) {
this.control.set(id, ctrl)
}
if (ihave) {
this.gossip.set(id, ihave)
}

return false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wemeetagain instead of having to throw an error, why don't we do the "stream is full" check here? try / catch needlessly is expensive

}

this.metrics?.onRpcSent(rpc, rpcBytes.length)

Expand Down