fix: catch errored push of rpc #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 79.80% // Head: 79.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #334 +/- ##
==========================================
- Coverage 79.80% 79.74% -0.06%
==========================================
Files 44 44
Lines 11082 11096 +14
Branches 1013 1016 +3
==========================================
+ Hits 8844 8849 +5
- Misses 2238 2247 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dapplion
reviewed
Aug 26, 2022
| this.gossip.set(id, ihave) | ||
| } | ||
|
|
||
| return false |
There was a problem hiding this comment.
@wemeetagain instead of having to throw an error, why don't we do the "stream is full" check here? try / catch needlessly is expensive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #325 , pushing an rpc thru the outbound stream can now throw.
This error should be caught to avoid interrupting publishing and forwarding messages.