Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(design): Design for db.Backend integration #4441

Merged
merged 2 commits into from
Jan 16, 2025
Merged

docs(design): Design for db.Backend integration #4441

merged 2 commits into from
Jan 16, 2025

Conversation

timwu20
Copy link
Contributor

@timwu20 timwu20 commented Jan 10, 2025

Changes

  • Design for db.Backend integration

Issues

closes #4388

@timwu20 timwu20 requested a review from P1sar as a code owner January 10, 2025 22:56
Base automatically changed from tim/client-db to refactor/client-db January 11, 2025 03:33
@timwu20 timwu20 requested a review from jimjbrettj as a code owner January 11, 2025 03:33
@timwu20 timwu20 force-pushed the tim/design-client-db-integration branch from 44e7854 to a5822aa Compare January 11, 2025 03:36
haikoschol
haikoschol approved these changes Jan 13, 2025
View reviewed changes
@timwu20 @haikoschol
Update docs/docs/design/client-db-integration.md
dcdddcc 
Co-authored-by: Haiko Schol <hs@haikoschol.com>
dimartiro
dimartiro approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@dimartiro dimartiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great analysis and design! 👏

@timwu20 timwu20 merged commit 8fe8796 into refactor/client-db Jan 16, 2025
24 checks passed
@timwu20 timwu20 deleted the tim/design-client-db-integration branch January 16, 2025 15:15
timwu20 added a commit that referenced this pull request Jan 19, 2025
@timwu20 @haikoschol
docs(design): Design for db.Backend integration (#4441)
8cc1aa9 
Co-authored-by: Haiko Schol <hs@haikoschol.com>
timwu20 added a commit that referenced this pull request Feb 11, 2025
@timwu20 @haikoschol
docs(design): Design for db.Backend integration (#4441)
9258919 
Co-authored-by: Haiko Schol <hs@haikoschol.com>
timwu20 added a commit that referenced this pull request Feb 13, 2025
@timwu20 @haikoschol
docs(design): Design for db.Backend integration (#4441)
0f89bc2 
Co-authored-by: Haiko Schol <hs@haikoschol.com>
timwu20 added a commit that referenced this pull request Feb 13, 2025
@timwu20 @haikoschol
docs(design): Design for db.Backend integration (#4441)
bd25e42 
Co-authored-by: Haiko Schol <hs@haikoschol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haikoschol haikoschol haikoschol approved these changes

@dimartiro dimartiro dimartiro approved these changes

@P1sar P1sar Awaiting requested review from P1sar P1sar is a code owner

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timwu20 @haikoschol @dimartiro