Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14 Builtin Actors #311

Merged
merged 33 commits into from
Jul 2, 2024
Merged

V14 Builtin Actors #311

merged 33 commits into from
Jul 2, 2024

Conversation

sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Jun 21, 2024

Summary of changes
Changes introduced in this pull request:

  • Added v14 actors
  • Updated KNOWN_CIDS and all actor methods in fil-actor-interface.
  • Increase rust stack size to RUST_MIN_STACK=8388608 due to builtin::known_cids::tests::test_loading_static_value

Other information and links

https://github.com/filecoin-project/builtin-actors/releases/tag/v14.0.0-rc.1

@sudo-shashank sudo-shashank changed the title V14 builtin actors V14 Builtin Actors Jun 24, 2024
@sudo-shashank sudo-shashank marked this pull request as ready for review June 24, 2024 13:23
@sudo-shashank sudo-shashank requested a review from a team as a code owner June 24, 2024 13:23
@sudo-shashank sudo-shashank requested review from ruseinov and lemmih and removed request for a team June 24, 2024 13:23
@ruseinov ruseinov self-requested a review June 24, 2024 15:55
@sudo-shashank sudo-shashank marked this pull request as draft June 24, 2024 16:00
@sudo-shashank sudo-shashank marked this pull request as ready for review June 25, 2024 12:29
@ruseinov
Copy link
Contributor

@sudo-shashank are we considering rc1 stable?

@LesnyRumcajs
Copy link
Member

@sudo-shashank are we considering rc1 stable?

It is considered stable once testing is done, and we are confident that it will work correctly with the upcoming calibration network upgrade.

@ruseinov
Copy link
Contributor

@sudo-shashank are we considering rc1 stable?

It is considered stable once testing is done, and we are confident that it will work correctly with the upcoming calibration network upgrade.

What does this mean for this PR? I am assuming it'll need to hang here till it's confirmed stable.

@LesnyRumcajs
Copy link
Member

@sudo-shashank are we considering rc1 stable?

It is considered stable once testing is done, and we are confident that it will work correctly with the upcoming calibration network upgrade.

What does this mean for this PR? I am assuming it'll need to hang here till it's confirmed stable.

Yeah, until we test that it works correctly for the NV23 upgrade, there's just no point in merging it. I'll give a green light once it's done.

@sudo-shashank sudo-shashank added the Status: Do not merge Added to PRs that are not allowed to be merged. label Jun 27, 2024
@ruseinov ruseinov enabled auto-merge July 2, 2024 15:18
@ruseinov ruseinov added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit d79c5ec Jul 2, 2024
5 checks passed
@ruseinov ruseinov deleted the shashank/v14-actors branch July 2, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Do not merge Added to PRs that are not allowed to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants