Ground atmosphere/fog hue, saturation and brightness shifts

[bagnell]

Added atmosphereHueShift, atmosphereSaturationShift, and atmosphereBrightnessShift properties to Globe which shift the color of the ground atmosphere to match the hue, saturation, and brightness shifts of the sky atmosphere.

Fixes #4195.

[cesium-concierge]

Thanks for the pull request @bagnell!

• ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

• Cesium Viewer works.
• Works in 2D/CV.
• Works (or fails gracefully) in IE11.

---

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

[lilleyse]

@OmarShehata would you like to review?

[OmarShehata]

@bagnell this looks good to me! I like the updated Sandcastle example.

The only failing test is a color test in ModelSpec loads a glTF 2.0 model. It might just need a bigger epsilon?

[bagnell]

The only failing test is a color test in ModelSpec loads a glTF 2.0 model. It might just need a bigger epsilon?

These code changes don't affect anything in model so something else is causing that to fail.

[OmarShehata]

I'm still seeing a failure on that test. It seems like the epsilon was changed from 5 to 10 here:

13e9f12#diff-dfb89d32e0b83bc7b650d1c64c56bfb5

But even when I check out that commit, npm run build and npm run test that test is still failing.

[OmarShehata]

I should mention that test is also failing in master.

[bagnell]

I'm still seeing a failure on that test. It seems like the epsilon was changed from 5 to 10 here:

Right, so it shouldn't impact this PR and perhaps @lilleyse can take a look at it.

[OmarShehata]

I think we should merge this then since that failing test is unrelated and everything else looks good (I don't have commit access so I can't merge).

[lilleyse]

Thanks @OmarShehata for the review. I had fun trying out the updated demo. Once CI passes I'll merge.