Allow undefined GroundPolylineGeometry for data that filters to a single point #6704
Conversation
|
@likangning93, thanks for the pull request! Maintainers, we have a signed CLA from @likangning93, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
|
|
||
| var geometry = GroundPolylineGeometry.createGeometry(groundPolylineGeometry); | ||
|
|
||
| expect(geometry).not.toBeDefined(); |
There was a problem hiding this comment.
.not.toBeDefined() -> .toBeUndefined()
| @@ -457,6 +457,11 @@ define([ | |||
| cartographics = arrayRemoveDuplicates(cartographics, Cartographic.equalsEpsilon); | |||
| cartographicsLength = cartographics.length; | |||
|
|
|||
| // In order to support external data that may have errors we treat this as an empty geometry. | |||
There was a problem hiding this comment.
We generally don't use inline comments unless something is truly non-obvious. It's easy for the inline comments to get out of sync with the code when we make changes.
We honestly should probably remove most of the comments in the files you added.
|
@hpinkos updated! I took out a few comments... there were already some that were out of sync >_< |
|
Thanks @likangning93! Please open another PR to remove inline comments from other files you've committed. |
Fixes #6702