3D Tiles feature renames #3473
Merged
3D Tiles feature renames #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #3241. Spec change: CesiumGS/3d-tiles#59 |
| @@ -446,7 +446,7 @@ define([ | |||
| var vertexBuffer = collection._vertexBuffer; | |||
| var createVertexBuffer = collection._createVertexBuffer; | |||
|
|
|||
| var instancesLength = collection.length; | |||
| var featuresLength = collection.length; | |||
There was a problem hiding this comment.
Since ModelInstanceCollection isn't strictly a 3D Tiles class, I think instances makes more sense here.
There was a problem hiding this comment.
Ah, yes. Bad search and replace.
|
Just that comment, everything else looks good. |
|
Updated. The Sandcastle example is also updated. |
|
Alright this is ready to go. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batched3DModeltoCesium3DTileFeaturegetModeltogetFeaturebatchLength/instancesLengthtofeaturesLengthThis will create some trivial breaking changes for the
3d-tiles-sandcastlebranch.