Polygon on Terrain #2618
Polygon on Terrain #2618
Conversation
…culled by the near plane is a WIP.
Conflicts: Source/Renderer/UniformState.js
…command for the volume and to pause the camera for clipping.
…ex shader now properly finds intersections with the near plane.
| @@ -163,6 +163,7 @@ define([ | |||
| if (!defined(globeDepth._clearColorCommand)) { | |||
| globeDepth._clearColorCommand = new ClearCommand({ | |||
There was a problem hiding this comment.
Can we rename this since it clears more than color now?
|
Part of #2172. |
|
|
||
| var that = this; | ||
| this._uniformMap = { | ||
| centralBodyMinimumAltitude : function() { |
There was a problem hiding this comment.
Can we replace "central body" with "globe" throughout?
There was a problem hiding this comment.
Also, something like czm_globeMinimumHeight could be a good automatic uniform (get the data from the scene's globe's ellipsoid).
| { | ||
| vec4 position = czm_translateRelativeToEye(positionHigh, positionLow); | ||
|
|
||
| float delta = 1.0; // TODO: moving the vertex is a function of the view |
There was a problem hiding this comment.
And a function of the terrain geometric LOD.
|
@bagnell I did not run the code, but that is my first round of comments. Do you want me to look at anything else before/while you make the next round of changes? |
|
@bagnell not sure if I mentioned this yet, but I think it is worth having two shaders: a fast one for when the viewer is outside of the volume, and a slower/robust one for when the viewer is inside. |
NOTE: This is not ready to merge. Opening for early review. The PR is into the globe-depth branch so those files are not seen in the diff.
Development Sandcastle example