Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatic generation of WMTS Tile Matrix Set Labels #526

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

kring
Copy link
Member

@kring kring commented Nov 15, 2024

This was causing WMTS URLs to be built incorrectly, and so the overlay would fail to work.
Reported here:
https://community.cesium.com/t/ue5-3-unity2021/36516

@kring kring added this to the December 2024 Release milestone Nov 15, 2024
@j9liu
Copy link
Contributor

j9liu commented Nov 15, 2024

Thanks @kring ! I didn't test this -- don't think we have test data on hand for me to reproduce the error? -- but the change makes sense to me.

@j9liu j9liu merged commit 4fd947a into main Nov 15, 2024
7 checks passed
@j9liu j9liu deleted the wmts-tile-matrix-labels-fix branch November 15, 2024 18:31
@kring
Copy link
Member Author

kring commented Nov 15, 2024

Yeah I don't have good test data for this either. I tested it by putting http://localhost/{TileMatrix} in the url field and Test: in the tileMatrixSetLabelPrefix field. Requests for that URL would of course fail, and Cesium for Unity would print the failed URL. Before this fix, it would print http://localhost/, which is clearly wrong. After this fix, it would print http://localhost/Test:0, which is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants