Add AxisAlignedBox::fromPoints
#1114
Conversation
| @@ -1,9 +1,12 @@ | |||
| #pragma once | |||
|
|
|||
| #include <CesiumGeometry/Library.h> | |||
| #include "Library.h" | |||
There was a problem hiding this comment.
We used to do this for headers in the same directory, but lately we've just been using the qualified name in angle brackets for consistency.
There was a problem hiding this comment.
Okay! I thought that went against our style guide, but I'll revert it.
There was a problem hiding this comment.
It might be worth adding a section about #include style to the style guide? Especially since this is a change from SF.12.
There was a problem hiding this comment.
I reopened #991 noting this change.
There was a problem hiding this comment.
I can see doing this for #includes in headers, but a small peeve in .cpp files is that the angle brackets cause the relevant .h to get mixed with the other includes. In other words, if I have "MyFile.h", doing <MyFile.h> in MyFile.cpp potentially mixes it with the other includes due to sorting alphabetically. It's not the biggest deal in the world but I guess the first option feels more "right" :')
There was a problem hiding this comment.
That might be fixable with .clang-format
There was a problem hiding this comment.
Hm maybe not: llvm/llvm-project#39735
|
Thanks for the comments @kring ! This is ready for another look. |
|
Thanks @j9liu! |
This is just a helper function that I plan to use in #1111. That PR is getting a bit heavy, so I wanted to break it up into more digestible PRs.