Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6.x windows setup #1663

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

ajtribick
Copy link
Collaborator

Checking whether we can automate building the Windows installer

Based on top of #1662 but targeting 1.6.x for workflow triggering

@ajtribick ajtribick force-pushed the 1.6.x-windows-setup branch from b5beb8e to 31f2a10 Compare March 29, 2023 20:45
@ajtribick

This comment was marked as outdated.

@ajtribick ajtribick force-pushed the 1.6.x-windows-setup branch from 31f2a10 to c42a807 Compare March 29, 2023 21:10
@levinli303

This comment was marked as resolved.

@375gnu

This comment was marked as resolved.

@ajtribick ajtribick force-pushed the 1.6.x-windows-setup branch 2 times, most recently from 164b88c to 545341a Compare March 30, 2023 18:52
@ajtribick

This comment was marked as outdated.

@ajtribick ajtribick force-pushed the 1.6.x-windows-setup branch 6 times, most recently from 81b391c to d52240a Compare April 1, 2023 11:57
@ajtribick ajtribick force-pushed the 1.6.x-windows-setup branch from d52240a to d575c53 Compare April 1, 2023 12:58
@ajtribick ajtribick marked this pull request as ready for review April 1, 2023 13:52
@ajtribick ajtribick mentioned this pull request Apr 1, 2023
@ajtribick ajtribick requested review from 375gnu and levinli303 April 2, 2023 08:23
@ajtribick ajtribick force-pushed the 1.6.x-windows-setup branch from d575c53 to 9a2cd11 Compare April 2, 2023 08:44
- Upgrade vcxproj
- Retrieve dlls from build directories
- Use define for version number in Inno Setup
@ajtribick ajtribick force-pushed the 1.6.x-windows-setup branch from 9a2cd11 to 35bf569 Compare April 2, 2023 08:49
@ajtribick
Copy link
Collaborator Author

@375gnu - how would you prefer to handle merging this, since currently it contains the commit in #1662 - do you want to cherry-pick this into that PR, or merge this one?

@375gnu
Copy link
Collaborator

375gnu commented Apr 12, 2023

Let's merge this

@ajtribick ajtribick merged commit e9a70d6 into CelestiaProject:1.6.x Apr 13, 2023
@ajtribick ajtribick deleted the 1.6.x-windows-setup branch April 13, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants