Fix exceptions in media converter #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntiDog
suggested changes
Apr 30, 2019
Hyderow
force-pushed
the
STCC-188-mediaconverter
branch
from
fdb47b4 to
ddfdf7a
Compare
Hyderow
force-pushed
the
STCC-188-mediaconverter
branch
from
ddfdf7a to
6707fac
Compare
|
I think it would be better to not include the library in the repository as the dependencies for it are quite large(~76MB) including instructions for installation in the readme should be sufficient. |
AntiDog
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the npm package svg2png to do the conversion from svg to png, as batik can't handle some of the attributes in svg files that were introduced with Scratch3
Install with: npm install svg2png -g