Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ChaingraphNetworkProvider #263

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

PHCitizen
Copy link
Contributor

closes #249

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cashscript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 1:09pm

@mr-zwets
Copy link
Member

Thanks for the PR @PHCitizen 😄

One thing I noticed is that there's no extra tests for the new ChaingraphNetworkProvider
In the folder test you'll see /e2e/network, here we have tests for the network providers like FullStack.test.ts
So it would be great to have similar automated tests for the new ChaingraphNetworkProvider

Also could you change the target branch from master to next, this is were all the ongoing development happens for upcoming releases.

@PHCitizen PHCitizen changed the base branch from master to next January 28, 2025 10:41
@PHCitizen PHCitizen force-pushed the feat/chaingraph-provider branch from f403c1e to 67d7c14 Compare February 1, 2025 12:37
Copy link

vercel bot commented Feb 1, 2025

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@rkalis
Copy link
Member

rkalis commented Feb 4, 2025

Hey @PHCitizen thank you for creating this PR (and the other draft PR). We're currently busy with the debugging support for the advanced transaction builder and additional features for v0.11, so we will take a deeper look into your PR(s) when that is finished. You can follow that progress in #230, #257 and milestone v0.11. We expect to release that version around the May 15th upgrade or a little bit after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a 'chaingraphNetworkProvider'
3 participants