Configuration capabilities using ENV vars #15881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
manmorjim
changed the title
| def db_config | ||
| @@db_config ||= YAML.load(File.read(db_config_file)).freeze | ||
| @@db_config ||= begin |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Style/ClassVars: Replace class var @@db_config with a class instance var.
| end | ||
|
|
||
| def app_config | ||
| @@app_config ||= YAML.load_file(app_config_file).freeze | ||
| @@app_config ||= begin |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Style/ClassVars: Replace class var @@app_config with a class instance var.
manmorjim
force-pushed
the
chore/ch107871/configure-cartodb-project-with-environment
branch
from
99c9c70 to
8a08f89
Compare
| @@db_config ||= YAML.load(File.read(db_config_file)).freeze | ||
| @@db_config ||= begin | ||
| template = ERB.new File.new(db_config_file).read | ||
| YAML.load(template.result(binding)).freeze |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Security/YAMLLoad: Prefer using YAML.safe_load over YAML.load.
| @@app_config ||= YAML.load_file(app_config_file).freeze | ||
| @@app_config ||= begin | ||
| template = ERB.new File.new(app_config_file).read | ||
| YAML.load(template.result(binding)).freeze |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
Security/YAMLLoad: Prefer using YAML.safe_load over YAML.load.
thedae
reviewed
Oct 5, 2020
| else | ||
| File.join(config_files_root, 'config/database.yml') | ||
| end | ||
| "#{config_files_root}/config/#{ENV['RAILS_DATABASE_FILE'] || 'database.yml'}" |
thedae
approved these changes
Oct 5, 2020
manmorjim
deleted the
chore/ch107871/configure-cartodb-project-with-environment
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ERB templates in file configs.
More info in CH: https://app.clubhouse.io/cartoteam/story/107871/configure-cartodb-project-with-environment-variables