Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix to worker import path #86

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Conversation

oltionchampari
Copy link
Contributor

@oltionchampari oltionchampari commented Dec 2, 2021

Closes Caleydo/tdp_bi_bioinfodb#1317
Requires

Note also Caleydo/ordino_product#64, https://github.com/datavisyn/ordino_bi_vienna_product/pull/47

Summary

The issue was that the workers were being imported under the path app/ but they were available in the root directory
Added prefix tourdino to import path and added nginx path alias

Changes for the dev server

Extend devServerProxy object in your .yo-rc-workspace.json

"devServerProxy": {
    "/app/tourdino/*": {
      "target": "http://localhost:8080",
      "pathRewrite": {
        "^/app": ""
      },
      "secure": false
    }
  },

@oltionchampari oltionchampari added type: bug Something isn't working release: minor PR merge results in a new minor version labels Dec 2, 2021
@oltionchampari oltionchampari requested a review from thinkh December 2, 2021 10:11
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. It works in my tests.

@thinkh thinkh merged commit 91dbb6d into develop Dec 7, 2021
@thinkh thinkh deleted the och/worker-import-path branch December 7, 2021 14:49
thinkh added a commit that referenced this pull request Dec 7, 2021
Amended fix for #86

Otherwise the webpack import of tourdino will break
@dvvanessastoiber dvvanessastoiber mentioned this pull request Apr 27, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: minor PR merge results in a new minor version type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants