Remove outdated styles for link with Font Awesome 4 icon #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't find any TypeScript code or link in the UI.
thinkh
added
type: technical debt
keckelt
approved these changes
Jul 21, 2022
ghost
approved these changes
Aug 9, 2022
ghost
merged commit 
ghost
pushed a commit
that referenced
this pull request
Sep 8, 2022
* prepare next development version 6.0.1-SNAPSHOT * Fix LineUp data type icons in comparison The issue is present since we use Font Awesome from tdp_core for LineUp and disable the lu-font. This change imports the lu-font from the LineUp assets. It also fixes the icons for the numerical data type. * Prepare github changes * Update README.md * Remove circleci * prepare next dev version * Remove outdated styles for link with Font Awesome 4 icon (#100) Remove outdated styles for link w/ Font Awesome 4 icon I couldn't find any TypeScript code or link in the UI. * Update fontawesome * Update .yo-rc.json * Merge visyn_scripts * prepare release 7.0.0 * fix lint * fix lint * fix lint Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> Co-authored-by: anita-steiner <> Co-authored-by: Anita Steiner <anita.steiner@datavisyn.io>
ghost
pushed a commit
that referenced
this pull request
Sep 30, 2022
* prepare next development version 6.0.1-SNAPSHOT * Fix LineUp data type icons in comparison The issue is present since we use Font Awesome from tdp_core for LineUp and disable the lu-font. This change imports the lu-font from the LineUp assets. It also fixes the icons for the numerical data type. * Prepare github changes * Update README.md * Remove circleci * prepare next dev version * Remove outdated styles for link with Font Awesome 4 icon (#100) Remove outdated styles for link w/ Font Awesome 4 icon I couldn't find any TypeScript code or link in the UI. * Update fontawesome * Update .yo-rc.json * Merge visyn_scripts * prepare next dev version * fix lint * fix lint * prepare release 7.0.1 Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> Co-authored-by: anita-steiner <> Co-authored-by: Anita Steiner <anita.steiner@datavisyn.io>
Merged
dvvanessastoiber
added a commit
that referenced
this pull request
Jul 28, 2023
## What's Changed ### Bugfixes * Fix LineUp data type icons in comparison by @thinkh in #98 ### Chore * Remove outdated styles for link with Font Awesome 4 icon by @thinkh in #100 * Migration to visyn_core by @oltionchampari in #107 * React 18 Migration by @dvmoritzschoefl in #108 ## New Contributors * @dvmoritzschoefl made their first contribution in #108 **Full Changelog**: v7.0.1...v8.0.0
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading to Font Awesome 6, I saw that some styles are still using Font Awesome 4 code. I removed this style, because I couldn't find any TypeScript code or link in the UI.
@keckelt If you can confirm this please approve and merge this PR. Thanks.