Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-24186] Correct assert statement from disk_cache_load_volume #3329

Merged
merged 1 commit into from
Jan 20, 2022
Merged

[CBRD-24186] Correct assert statement from disk_cache_load_volume #3329

merged 1 commit into from
Jan 20, 2022

Conversation

jinbekim
Copy link
Contributor

http://jira.cubrid.org/browse/CBRD-24186

Purpose

  • Refactoring
  • Correct assert statement from disk_cache_load_volume as intended.

Implementation

  • nsect_total -> nsect_max
  • from
assert (disk_Cache->perm_purpose_info.extend_info.nsect_total
<= disk_Cache->perm_purpose_info.extend_info.nsect_total);
  • to
assert (disk_Cache->perm_purpose_info.extend_info.nsect_total
<= disk_Cache->perm_purpose_info.extend_info.nsect_max);

Remarks

  • N/A

Copy link
Contributor

@wrlawodms wrlawodms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution :)

@codecov-commenter
Copy link

Codecov Report

Merging #3329 (74c747f) into develop (7a764fd) will decrease coverage by 51.91%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3329       +/-   ##
============================================
- Coverage    51.91%    0.00%   -51.92%     
============================================
  Files          500      469       -31     
  Lines       397893   360689    -37204     
============================================
- Hits        206570        0   -206570     
- Misses      191323   360689   +169366     
Impacted Files Coverage Δ
src/base/porting.h 0.00% <0.00%> (-100.00%) ⬇️
src/base/packer.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/base/base_flag.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/parser/parse_tree.h 0.00% <0.00%> (-100.00%) ⬇️
src/parser/func_type.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/xasl/access_spec.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/parser/parse_type.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/loaddb/load_common.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/xasl/xasl_analytic.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/storage/btree_unique.hpp 0.00% <0.00%> (-100.00%) ⬇️
... and 378 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a764fd...74c747f. Read the comment docs.

@hornetmj hornetmj merged commit 48a5450 into CUBRID:develop Jan 20, 2022
hornetmj pushed a commit that referenced this pull request Jan 21, 2022
…ous fix (#3335)

http://jira.cubrid.org/browse/CBRD-24186

Fix build error in debug mode due to typo from the previous fix. (#3329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants