Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add densitytensor notebook #59

Merged
merged 5 commits into from
Jan 19, 2023
Merged

Add densitytensor notebook #59

merged 5 commits into from
Jan 19, 2023

Conversation

SamDuffield
Copy link
Contributor

Added example notebook demonstrating densitytensor simulator

@SamDuffield SamDuffield requested a review from erinaldiq January 19, 2023 08:39
Copy link
Collaborator

@erinaldiq erinaldiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition to the examples.

One sentence I would clarify is

Now let's sample some measurements from the true $p$

It sounds strange to sample from $p$. What we actually do is sample from both the noiseless and the noisy circuit with noise parameters $p$.

@SamDuffield
Copy link
Contributor Author

Great addition to the examples.

One sentence I would clarify is

Now let's sample some measurements from the true $p$

It sounds strange to sample from p. What we actually do is sample from both the noiseless and the noisy circuit with noise parameters p.

Good point! Yeah really what we sample are "noisy measurements from the circuit with noise parameter $p$"

@SamDuffield SamDuffield merged commit 5dc2a4e into develop Jan 19, 2023
@SamDuffield SamDuffield deleted the dt-notebook branch January 19, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants