Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Cargo.lock, fix builds on 1.75 #1942

Merged
merged 1 commit into from
Feb 28, 2025
Merged

chore: Add Cargo.lock, fix builds on 1.75 #1942

merged 1 commit into from
Feb 28, 2025

Conversation

aborgna-q
Copy link
Collaborator

icu4x bumped its MSRV to 1.81 for all of it's sub-crates in a minor release. This means that we can no longer build hugr with 1.75.

This PR unignores the Cargo.lock and cargo updates the dependencies to downgrade them to a supported version. We should see the 1.75 CI job fail if dependabot tries to update them again.

This problem is caused by the dependency resolver v2 ignoring the rust-version field in the crates. In rust 2024 the new v3 resolver should be able to use only valid versions, but we have a long way until we are able to use that.

@aborgna-q aborgna-q requested a review from a team as a code owner February 27, 2025 15:55
@aborgna-q aborgna-q requested a review from mark-koch February 27, 2025 15:55
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.69%. Comparing base (7a9bda5) to head (003357d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1942   +/-   ##
=======================================
  Coverage   83.69%   83.69%           
=======================================
  Files         196      196           
  Lines       37691    37691           
  Branches    34504    34504           
=======================================
  Hits        31546    31546           
  Misses       4359     4359           
  Partials     1786     1786           
Flag Coverage Δ
python 92.34% <ø> (ø)
rust 82.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aborgna-q aborgna-q enabled auto-merge February 27, 2025 16:00
@aborgna-q aborgna-q requested a review from cqc-alec February 27, 2025 18:58
@aborgna-q aborgna-q added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit f667b4e Feb 28, 2025
25 checks passed
@aborgna-q aborgna-q deleted the ab/pin-175-deps branch February 28, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants