Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file deletion when rotating and some bugfixes #718

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix file deletion when rotating and some bugfixes #718

wants to merge 7 commits into from

Conversation

andreasbank
Copy link
Contributor

  • Fix file deletion when rotating
  • Correct mutexattr init
  • Small code cleanup and improvements
  • Properly terminate log messages

@andreasbank andreasbank changed the title Some bugfixes and improvements Fix file deletion when rotating and some bugfixes Dec 9, 2024
@minminlittleshrimp
Copy link
Collaborator

Close by mistake, please check #732 for upcoming vers.

averater and others added 7 commits March 11, 2025 08:45
@averater @andreasbank
Fix file length calculation
ec8e385 
dlt_logstorage_log_file_name assumed the suffix always is .dlt which
is not be the case if gzip compression is enabled. Changed to assume
.dlt.gz when smax is calculated as it prevents buffer overflow if
filenames are long and gzip is enabled.
@averater @andreasbank
typo
0b6fed5
@averater @andreasbank
Make file suffix dependent on gzip compression
a9b3cdc
@andreasbank
Delete all excess log files
3cd23d5 
If there are more files than the configuration allows, delete them all,
not just the last one
@andreasbank
Use the correct mutexattrib init function
2932f48
@andreasbank
Don't use strncat with size of src
3e0b495 
strncat() already searches for the null-term in src, making strlen()
completely useless.
@andreasbank
Add proper log termination
9cf1806 
Without the newline character multiple logs get concatenated
into a single log.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minminlittleshrimp minminlittleshrimp minminlittleshrimp left review comments

@lti9hc lti9hc lti9hc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreasbank @minminlittleshrimp @lti9hc @averater