-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split dlt_common and dlt_log #483
refactor: split dlt_common and dlt_log #483
Conversation
@michael-methner Here my refactor PR like discussed at #369 (comment) |
d318093
to
7620b87
Compare
Hello @michael-methner |
Hello @michael-methner , Thank you in advance! |
Hello @michael-methner , |
Hello @danielweber2018 , thanks for your patience. I had a quick glance at the commit and I think is fine and a desirable change. I think it's good to spent some efforts on refactoring to keep the DLT code maintainable. So please go ahead with your planned rework. I will then review it. I guess reviewing it is not that much of an effort as it is mainly moving code and and not modifying the logic of it. |
Hello @michael-methner , |
Seperate all internal logging function into an own source file. This reduces the scope of the sprawling dlt_common source file.
7620b87
to
da3bde3
Compare
Hello @michael-methner and @minminlittleshrimp , |
Hello @michael-methner and @minminlittleshrimp , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with your change, it is a refactoring only and no APIs affected.
Approve and merge!
Seems to have merge conflict, let me take sometimes to fix |
Hello @danielweber2018 |
No response from contributor, create new one & set this to duplicated. Close and continue on: #657 |
Seperate all internal logging function into an own source file. This reduces the scope of the sprawling dlt_common source file.
The program was tested solely for our own use cases, which might differ from yours.
Licensed under Mozilla Public License Version 2.0
Daniel Weber, daniel.w.weber@mercedes-benz.com, Mercedes-Benz Technology Innovation GmbH, imprint