Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor, use global_Id instead of raw value in Filter #105

Conversation

Zrealshadow
Copy link
Collaborator

No description provided.

@KimballCai KimballCai added the structure-adjust Adjust project structure or internal data structure label Sep 14, 2022
@Zrealshadow Zrealshadow marked this pull request as ready for review October 18, 2022 13:59
@Zrealshadow
Copy link
Collaborator Author

Can not pass MetaCubeTest.
I have modified some interface of storage layer.
Some functions of storage layer are outdated.

@Zrealshadow
Copy link
Collaborator Author

I have modified some interface in io layer.
Maybe CubletSave function have to re-implement based on new interface.
Then we can pass all unit test

@Zrealshadow
Copy link
Collaborator Author

disable two failed unittest

 dataChunkProceesTest(com.nus.cool.core.iceberg.query.IcebergSelectionTest)
 iceBergTest(com.nus.cool.functionality.IcebergLoaderTest)

@NLGithubWP will refactor iceBerg part. these two unittest for old version olap engine will be disabled temporarily

@KimballCai
Copy link
Contributor

The code format has not been checked. Need to open another PR to format these codes.

@hugy718
Copy link
Collaborator

hugy718 commented Nov 2, 2022

There are so many files that have no meaningful changes but with their formats reverted back to codes before formatting. I just discussed with @Zrealshadow, and the plan is to open a new branch from dev, so that we all have write access to it. Open a new PR from that branch to dev. As we review the codes, we check if the diff is mere code formatting and use the dev branch files to replace their contents. @NLGithubWP @KimballCai

@hugy718 hugy718 changed the base branch from dev to refactor-use-global-id-for-processing November 2, 2022 14:56
@Zrealshadow
Copy link
Collaborator Author

OK, refactor part is all formatted.

@KimballCai KimballCai merged commit 24dc2d0 into COOL-cohort:refactor-use-global-id-for-processing Nov 3, 2022
@Zrealshadow Zrealshadow deleted the gidInFilter branch November 4, 2022 04:56
@KimballCai KimballCai linked an issue Nov 23, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
structure-adjust Adjust project structure or internal data structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement in UserMetaField part
3 participants