-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add anonymous posting and reply #36
Conversation
Pull Request Test Coverage Report for Build 13336189913Details
💛 - Coveralls |
My original pull request was just the first four commits. I ask Kareem whether if I push new commits to the feature branch, will it add the commits to this pull request, and he asked no. So, this wasn't meant to be a large pull request. The original pull request: How was it tested: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review Conducted
- no issues
- changes are easily readable, easy to understand changes
- .tpl changes appear to be front end changes
- .yaml files seem to be for updating the user interface to accommodate for the newdata.anonymous
data field
- changes to .js files seem to also be for updating for newdata.anonymous
data field
-src/user/create.js
andsrc/socket.io/user/status.js
changes seem to be for implementation of anonymous functionality wheredata.anonymous
data field is utilized and modified
What is Change:
These change allows user to post anonymously under anonymous status and when the admin allow anonymous posting. These change also include a small fix for the status changes, where before this change, the status frontend changes were not updating properly.
How was it tested:
These changes were tested by running
npm run test
.Next steps:
There are still changes need to make sure no reveal of user data and allowing admins to see the anonymous post without any hidden.
Link: #33