Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anonymous posting and reply #36

Merged
merged 7 commits into from
Feb 20, 2025
Merged

Add anonymous posting and reply #36

merged 7 commits into from
Feb 20, 2025

Conversation

VallinZ
Copy link
Contributor

@VallinZ VallinZ commented Feb 13, 2025

What is Change:
These change allows user to post anonymously under anonymous status and when the admin allow anonymous posting. These change also include a small fix for the status changes, where before this change, the status frontend changes were not updating properly.

How was it tested:
These changes were tested by running npm run test.

Next steps:
There are still changes need to make sure no reveal of user data and allowing admins to see the anonymous post without any hidden.

Link: #33

@VallinZ VallinZ requested a review from lesliehuh February 13, 2025 21:06
@VallinZ VallinZ changed the title Enable anonymous posting frontend for topics Add anonymous field for user and topic Feb 13, 2025
@coveralls
Copy link

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13336189913

Details

  • 17 of 35 (48.57%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 82.598%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/socket.io/user/status.js 2 3 66.67%
src/topics/create.js 10 12 83.33%
public/src/modules/helpers.common.js 5 20 25.0%
Files with Coverage Reduction New Missed Lines %
public/src/modules/helpers.common.js 1 72.27%
Totals Coverage Status
Change from base Build 13271971727: -0.07%
Covered Lines: 22340
Relevant Lines: 25619

💛 - Coveralls

@VallinZ
Copy link
Contributor Author

VallinZ commented Feb 14, 2025

My original pull request was just the first four commits. I ask Kareem whether if I push new commits to the feature branch, will it add the commits to this pull request, and he asked no. So, this wasn't meant to be a large pull request.

The original pull request:
Title: Add anonymous field for user and topic
Description:
What is Change:
These change is adds an anonymous field to user and topic data, where the field is future used to enable frontend changes. These change also include a small fix for the status changes, where before this change, the status frontend changes were not updating properly.

How was it tested:
These changes were tested by running npm run test.

@VallinZ VallinZ changed the title Add anonymous field for user and topic Add anonymous posting and reply Feb 14, 2025
Copy link
Contributor

@lesliehuh lesliehuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Conducted

  • no issues
  • changes are easily readable, easy to understand changes
     - .tpl changes appear to be front end changes
     - .yaml files seem to be for updating the user interface to accommodate for the new data.anonymous data field
     - changes to .js files seem to also be for updating for new data.anonymous data field
     -src/user/create.js and src/socket.io/user/status.js changes seem to be for implementation of anonymous functionality where data.anonymous data field is utilized and modified

@lesliehuh lesliehuh merged commit 4e1743d into main Feb 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants