Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the Pinned Reply move to the top (refresh does not preserve) #20

Merged
merged 3 commits into from
Feb 9, 2025

Conversation

ChristinaTrinh
Copy link
Contributor

  • I added a backend logic to make Pinned Reply move to the top.
  • However, I have not made any API calls, therefore, when refreshing the page, it will NOT stay as it is supposed to. This involves much more work so will be done later. The following tasks need to be done to make the changes preserved after refreshing page:
    + Add a 'pinned' field to the database schema for posts: I have not figured how to do this but I spent hours on looking for example with the Bookmark Post feature.
    + Create API endpoints to handle pinning and unpinning: this looks like it's involving like 15+ files so it's not doable for this sprint.
    + Adjust frontend to send requests to these endpoints when posts are pinned/unpinned
  • I tested the changes locally.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13223159975

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 82.666%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 13222395496: -0.005%
Covered Lines: 22322
Relevant Lines: 25582

💛 - Coveralls

@ChristinaTrinh ChristinaTrinh merged commit 51f421d into CMU-313:main Feb 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants