Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2234 Feature: move dialogs to dialogs folder #2270

Merged
merged 4 commits into from
Jun 27, 2023

Conversation

JeremyTremblay2
Copy link
Contributor

@JeremyTremblay2 JeremyTremblay2 commented Jun 27, 2023

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@JeremyTremblay2 JeremyTremblay2 requested a review from a team as a code owner June 27, 2023 12:25
@JeremyTremblay2 JeremyTremblay2 changed the title #2022 Feature: move dialogs to dialogs folder #2234 Feature: move dialogs to dialogs folder Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +88.43 🎉

Comparison is base (dca312d) 0.00% compared to head (12245df) 88.43%.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2270       +/-   ##
=========================================
+ Coverage      0   88.43%   +88.43%     
=========================================
  Files         0      296      +296     
  Lines         0    11314    +11314     
=========================================
+ Hits          0    10006    +10006     
- Misses        0     1308     +1308     
Impacted Files Coverage Δ
....Portal.Client/Components/Devices/EditDevice.razor 93.87% <ø> (ø)
...lient/Dialogs/Devices/ConnectionStringDialog.razor 41.30% <ø> (ø)
...al.Client/Dialogs/Devices/ImportReportDialog.razor 100.00% <ø> (ø)
...nt/Dialogs/Devices/LoRaDeviceTelemetryDialog.razor 100.00% <ø> (ø)
...t/Dialogs/EdgeDevices/ConnectionStringDialog.razor 43.63% <ø> (ø)
...geDevices/EdgeDeviceDeleteConfirmationDialog.razor 100.00% <ø> (ø)
....Client/Dialogs/EdgeDevices/ModuleLogsDialog.razor 100.00% <ø> (ø)
...ent/Dialogs/EdgeModels/DeleteEdgeModelDialog.razor 94.44% <ø> (ø)
...t/Dialogs/EdgeModels/EdgeModule/ModuleDialog.razor 100.00% <ø> (ø)
...alogs/EdgeModels/EdgeModule/ModuleDialogTab1.razor 100.00% <ø> (ø)
... and 13 more

... and 273 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand force-pushed the Feature/2022_move_dialogs_to_dialogs_folder branch from 15204ea to 12245df Compare June 27, 2023 12:30
@kbeaugrand kbeaugrand enabled auto-merge (squash) June 27, 2023 12:33
@kbeaugrand kbeaugrand merged commit d97a77b into main Jun 27, 2023
@kbeaugrand kbeaugrand deleted the Feature/2022_move_dialogs_to_dialogs_folder branch June 27, 2023 12:45
@JeremyTremblay2 JeremyTremblay2 linked an issue Jun 27, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Move Dialogs to Dialogs folder
2 participants