-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CVSS Qualitative Severity Rating Scale decision point #712
Add CVSS Qualitative Severity Rating Scale decision point #712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
key="QS", | ||
description="The CVSS Qualitative Severity Rating Scale provides " | ||
"a categorical representation of a CVSS Score.", | ||
version="1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lingering CVSS versioning question on my mind. May be it should be an issue. The CVSS V4 is sometime represented with namespace
version
combo of cvss
and 3.0.1
like in ATTACK_VECTOR_3_0_1 (in src/ssvc/decision_points/cvss/attack_vector.py file) for CVSS v4 Attack Vector
- can we track mapping this way? This seems to be the case in this PR as well where CVSSv4 Quality metric shows us as version 1.0.0
with names space cvss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The decision point versions are the decision point versions. They have no connection to CVSS versions.
The qualitative severity scale was added in CVSS v3.0 and has not changed (search each of these for "qualitative severity" to confirm), so by our decision point versioning rules, this one is 1.0.0
.
include_json:bool
option (defaults toTrue
) on theexample_block()
method so that docs can ask for a defined decision point block without thejson
example being included (by explicitly passinginclude_json=False
)example_block()
accepted but did not use anindent:int
parameterCopilot Summary (edited to add CVSS spec link)
This pull request introduces a new decision point for the CVSS Qualitative Severity Rating Scale and updates the documentation accordingly. The most important changes include adding the new decision point, updating the documentation to include it, and modifying helper functions to support the new decision point.
Addition of CVSS Qualitative Severity Rating Scale:
src/ssvc/decision_points/cvss/qualitative_severity.py
: Added a new decision point for the CVSS Qualitative Severity Rating Scale, including definitions for different severity levels and a main function to print versions and diffs.Documentation updates:
docs/reference/decision_points/cvss/qualitative_severity.md
: Added documentation for the CVSS Qualitative Severity Rating Scale, including an example block.mkdocs.yml
: Updated the navigation to include the new Qualitative Severity documentation under CVSS-based decision points.Helper function modifications:
src/ssvc/doc_helpers.py
: Modified theexample_block
function to include an optional JSON example and changed the indentation parameter to be more flexible. [1] [2]