Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Matomo API tracking code and Celery task queue #820

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

sfisher
Copy link
Contributor

@sfisher sfisher commented Jan 13, 2025

See #728 and #757 .

This gets rid of API tracking code and also removes Celery task queue and SQLAlchemy (required by Celery).

Things to do after deploy: remove Celery DB tables manually and remove the token for Matomo from SSM which isn't used anymore.

I already checked with Ashley and she removed the startup of the service/daemon for Celery on stage/production. 🎉

Also we can archive the forked repo on github.

…seems to have some breaking configuration changes currently. I'll cherry pick this commit into it's own pull request if this works.
… tracking. Still need to remove server starting of proc-celery and db tables and auth_token from ssm.
@sfisher sfisher requested a review from jsjiang January 13, 2025 22:56
@sfisher sfisher linked an issue Jan 13, 2025 that may be closed by this pull request
@sfisher sfisher changed the base branch from main to develop February 18, 2025 19:42
@sfisher
Copy link
Contributor Author

sfisher commented Feb 18, 2025

It seems like Adam would like to go ahead with the changes in a bunch of tickets for text changes and accessibility changes rather than waiting for Jing to return in March.

There are revisions to the info-pages repo and also revisions to the main application. All these changes are combined and deployed to dev with the accessibility-rollup01 branch and the info-pages branch informational-revision checked out in templates/info (until it gets merged in to the main branch there).

@sfisher sfisher requested a review from datadavev February 18, 2025 20:29
Copy link
Contributor

@datadavev datadavev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's reference to matomo in the temples (e.g. layouts/base.html) that should be cleaned up as well if matomo is being completely removed.

@sfisher
Copy link
Contributor Author

sfisher commented Feb 19, 2025

It was decided to leave the UI tracker in place but to clean up the API tracking since the UI Javascript tracker has minimal impact and may be useful at some point.

@sfisher sfisher merged commit 3f19862 into develop Feb 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MAINTENANCE] Remove Matomo API Tracking Code
2 participants