Dibbs ECR Viewer repo update, NBS_AUTH usage and database var changes 🎊
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces more granular secret handling for database and SQL server parameters, adjusts the ECR repository for viewer, and adds 'nbs auth' variable. In the ECS task configuration, a few more properties are specified for container definitions, and the re-deployment trigger in ECS service has been updated to include version in addition to timestamp.
alismx
changed the title
CONFIG_NAME env usage 🎊
alismx
changed the title
CONFIG_NAME env usage 🎊 NBS_AUTH env usage and database var changes 🎊
alismx
changed the title
NBS_AUTH env usage and database var changes 🎊 NBS_AUTH usage and database var changes 🎊
rin-skylight
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Changes Proposed
Additional Info
Testing