Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade cypress chrome version #6289

Merged
merged 2 commits into from
Aug 8, 2023
Merged

upgrade cypress chrome version #6289

merged 2 commits into from
Aug 8, 2023

Conversation

zdeveloper
Copy link
Contributor

@zdeveloper zdeveloper commented Aug 7, 2023 •
edited
Loading

E2E PULL REQUEST

Changes Proposed

  • upgrade cypress chrome version to 114
  • install curl since they removed it from the latest image
  • give chrome more ram (hoping it will improve the hanging issue based on this)

@zdeveloper zdeveloper force-pushed the zedd/update-cypress-chrome-image branch from be3a5af to a08679b Compare August 7, 2023 21:08
@zdeveloper zdeveloper requested review from BobanL, alismx and nathancrtr and removed request for BobanL August 7, 2023 21:18
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zdeveloper zdeveloper marked this pull request as ready for review August 7, 2023 21:20
@zdeveloper zdeveloper requested a review from mpbrown August 7, 2023 21:20
alismx
alismx approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@alismx alismx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to go.

I don't mind handing out more RAM, but let's watch for signs of other OOM issues.

@zdeveloper zdeveloper added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit 90f29d1 Aug 8, 2023
@zdeveloper zdeveloper deleted the zedd/update-cypress-chrome-image branch August 8, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobanL BobanL BobanL approved these changes

@alismx alismx alismx approved these changes

@nathancrtr nathancrtr Awaiting requested review from nathancrtr

@mpbrown mpbrown Awaiting requested review from mpbrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zdeveloper @BobanL @alismx