fix(workflows): remove dupe, update workflows for bulding main, workflow_dispatch, repo_dispatch 🥟 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update GitHub workflows to incorporate repository dispatch and workflow dispatch for service builds. Refactor packer job configuration for both - changes trigger and specific service build. Add service and version as configurable dispatch inputs.
alismx
force-pushed
the
alis/workflow_fix_1
branch
6 times, most recently
from
6e1effe to
ae5adb0
Compare
alismx
changed the title
alismx
changed the title
alismx
added
Cloud Enablement
rin-skylight
approved these changes
Mar 6, 2025
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Packer | ||
| uses: hashicorp/setup-packer@1aa358be5cf73883762b302a3a03abd66e75b232 |
There was a problem hiding this comment.
Random question...(non-blocking, no action required)...is there a reason why we're using the hash value for this instead of a version? I noticed this pop up, and I wasn't sure if it was intentional or a new best practice that I missed.
There was a problem hiding this comment.
The practice of using the commit hash does seem to be preferred these days. This was changed because of this alert: https://github.com/CDCgov/dibbs-vm/security/code-scanning/7
We may want to decide how to approach this as a team, but I have started pinning with a commit hashes.
.github/workflows/packMachines.yml
Outdated
| # Needed for ISO builder | ||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@4574d27a4764455b42196d70a065bc6853246a25 | ||
| # - name: Set up QEMU |
There was a problem hiding this comment.
Sorry for all the trouble on this...I should have tested before I threw this in as a framework. 😭
EmmanuelNwa247
approved these changes
Mar 6, 2025
alismx
force-pushed
the
alis/workflow_fix_1
branch
from
ae5adb0 to
ffc0541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed
docker-setup-qemuaction to work in this context, if anybody knows how to fix this issue LMK!)Additional Information
Testing
Run workflowalis/workflow_fix_1branchmainshould work