-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eCR Viewer setup script + variable pattern setting 🖌️ #51
Conversation
…docker-compose This commit updates the environment variables configurations across different services and updates the services docker images to v2.0.0-beta in the docker-compose.yml file. Also, includes user guides for VM launch in AWS and Proxmox environments.
…er structure, add VM build script
I converted back to draft because the environment variables did not stay set in the ways I expected. I'll reopen this for review shortly. |
Refactor the handling of environment variables in dibbs-ecr-viewer docker configuration. Migrate environment variables from hard-coded settings in ecr-viewer.env file to dynamic generation using a wizard script. Add backup for old environment settings. Update gitignore to include new .env files and backups.
…uild process scripts
…naming convention
…e and docker-compose.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks AMAZING. I have two small thoughts that may require edits, but nothing that makes me slam the stop button. I'll happily issue an approval once I hear your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully ran the build script and deployed the image for ecr-viewer. This PR provided us with a lot of the foundation we need moving forward. 🚀
Changes Proposed
dibbs_service
anddibbs_version
to enable selecting a dibbs project during builds..gitignore
~/.bashrc
file which sets vars across rebootspackMachines.yml
, to create Docker images dynamically based on provided service and version inputs.docker-compose.yml
to remove hardcoded image versions and allow the version to be set as an environment variable at build time.build.sh
script is also included inutils/
for executing the Packer build with the required service and version variables.Additional Information
Testing
Reviewers can verify these changes by:
./build.sh dibbs-ecr-viewer v2.0.0-beta
sudo ./wizard.sh