Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow cleanup, dibbs-ecr-viewer version, speed up redeploys 💨 #51

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

alismx
Copy link
Collaborator

@alismx alismx commented Feb 20, 2025

Changes Proposed

  • Workflow cleanup:
    • remove unneeded Github context from inputs calls
    • update run-name with version
    • update concurrency names with id
    • add variables for version and route53 hosted zone
    • add gates for workspace names (we only want to allow deletion of dev environments, not prod)
  • PostgreSQL setup improvements
    • ignore specific fields so that the aws_instance scripts only run once
  • OIDC
    • add some permissions for environment destruction

Testing

Please let me know if something isn't clear with these testing steps.

Terraform Apply

  • Run this deploy action with the following settings: https://github.com/CDCgov/dibbs-aws/actions/workflows/deployment_apply.yaml
    • Use workflow from
      • Branch: alis/env_followup
    • The workspace to terraform against
      • dev
    • The id of the environment (PR number, etc.) # pick a number or short string you like
      • 42
    • The version of dibbs-ecr-viewer
      • main or v2.0.0-beta # needs to be a version that has docker images built, defaults to beta
    • Click Run Workflow (~8.5 minutes)
    • Check the terraform output and for any errors in the logs
    • View your new environment at dev<ID_YOU_PICKED>.dibbs.cloud
    • You can also run a redeploy and see that it only takes 30 seconds instead of several minutes

Terraform destroy

  • Run this destroy action with the following settings: https://github.com/CDCgov/dibbs-aws/actions/workflows/deployment_destroy.yaml
  • Use workflow from
    • Branch: alis/env_followup
  • The workspace to terraform against
    • dev
  • The id of the environment (PR number, etc.)
    • 42 # the same number you used above
  • Click Run Workflow (~6.5 minutes)
  • Check the terraform output and for any errors in the logs
  • Verify the environment has been destroyed

@alismx alismx force-pushed the alis/env_followup branch 14 times, most recently from f66339c to eb6cc8e Compare February 20, 2025 20:56
…nd enhance terraform infrastructure security
@alismx alismx changed the title feat: add dibbs-ecr-viewer-version to deployment_apply workflow and u… Workflow cleanup, dibbs-ecr-viewer version, speed up redeploys 💨 Feb 20, 2025
@alismx alismx self-assigned this Feb 20, 2025
@alismx alismx added aws Cloud Enablement Issues related to DevOps or security that need specialized attention from DevSecOps personnel Streamline eCR Issues for Streamline eCR team to work on labels Feb 20, 2025
@alismx alismx marked this pull request as ready for review February 20, 2025 21:25
@alismx alismx merged commit 0db5a3f into main Feb 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Cloud Enablement Issues related to DevOps or security that need specialized attention from DevSecOps personnel Streamline eCR Issues for Streamline eCR team to work on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant