-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disposable - Replace magazines in backpack when launcher fits backpacks #1485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- No need to make a config entry for this, because it already is one with the "WeaponsSlotsInfo\allowedSlots" array.
- No need to maintain a list when we can abuse HashMaps as sets. Lookup in list is O(n) at worts, while lookup in set is O(1).
Disclaimer, suggestions not tested, so there may be typos or logic holes.
|
Such is life. |
lgtm Did you test if it works? |
Yeah, works fine. |
I don't know. It seems not really necessary. |
Co-authored-by: commy2 <commy-2@gmx.de>
Good job :) |
When merged this pull request will:
launcher_loaded >> WeaponSlotsInfo >> allowedSlots
array, implements Allow Disposable Launchers to be replaced in Backpacks #1356)