-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LM Toolkit Refactor #381
base: 2.0.0
Are you sure you want to change the base?
LM Toolkit Refactor #381
Conversation
TODO: finish processing script, integrate LLM
…ed in that package now
… textpredict package
…xtpredict's exception
Merging changes from removing unigram model
Merging unigram removal into toolkit refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait for @lawhead to review since he has more experience here. I would keep the base class as LanguageModel
or BciPyLanguageModel
, but the others could be annotated as Adapters extending from that. We may want our own Uniform here without an adapter. I understand why you need it in the toolkit, but it's simple enough to keep here, and it could be a good example of how to build an LM in BciPy.
The toolkit doesn't seem to work for 3.10.6. >=3.7,<3.11?
Also, some linting errors!
Merging toolkit refactor into Banff LM branch for sim testing.
Overview
Replaced all custom models in the language module with language model adapters. Adapters rely on aactextpredict, our new LM toolkit, for the heavy lifting and only need to handle BciPy-specific things like special space and backspace characters and response type properties.
Ticket
Link a pivotal ticket here
Contributions
Test
Documentation
Changelog