Static Offset per Device #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tab-cmd
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Thanks for this update! This looks exactly as I would have envisioned it. In offline analysis, if wanting to use an offset for a different device, we'd only need to pull it from the spec. @celikbasak will need to review but this should work well for us.
celikbasak
reviewed
Jul 16, 2024
| @@ -26,6 +27,7 @@ def setUp(self): | |||
| self.gaze_device_mock.content_type = 'Eyetracker' | |||
| self.gaze_device_mock.sample_rate = 60 | |||
| self.gaze_device_mock.is_active = False | |||
| self.gaze_device_mock.static_offset = 0.0 | |||
There was a problem hiding this comment.
It is currently assumed 0.0 for my analyses as well, but I will think of a way to estimate the correct value
celikbasak
reviewed
Jul 16, 2024
| @@ -120,6 +124,7 @@ | |||
| "sample_rate": 60.0, | |||
| "description": "Tobii Nano. For use with the Tobii Pro SDK.", | |||
| "excluded_from_analysis": ["device_ts", "system_ts", "left_pupil", "right_pupil"], | |||
| "status": "active" | |||
| "status": "active", | |||
| "static_offset": 0.0 | |||
celikbasak
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactored code to allow configuration of a static_offset value for each device, rather than a global value set in the parameters.json.
Ticket
https://www.pivotaltracker.com/story/show/187737714
Contributions
Test