Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multimodal #294

Merged
merged 59 commits into from
Nov 16, 2023
Merged

Multimodal #294

merged 59 commits into from
Nov 16, 2023

Conversation

celikbasak
Copy link
Member

Overview

Offline analysis of multimodal fusion & Add visualize eye data method

Ticket

https://www.pivotaltracker.com/story/show/185036543
https://www.pivotaltracker.com/story/show/182667460

Contributions

  • Initial version of the gaze model is completed. Model is trained & validated with all multimodal subjects' data.
  • Gaze reshaper, triggers, and model refinement.
  • Updates in offline_analysis to include both EEG and gaze analyses.
  • Visualization for gaze inquiries and gaze model are completed.

Test

  • Unit tests for Signal module passed.
  • Unit tests for Helpers module passed, with the exception of load_raw_data in some modules needs to be updated (missing 1 positional argument after the multimodal update).
  • Offline analysis completed for all (N=20) Multimodal subjects.

Documentation

  • Are documentation updates required? In-line, README, or documentation? Verify the updates you did here. Documentation not updated yet!

Changelog

  • CHANGELOG.md is updated

Copy link
Collaborator

@lawhead lawhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to get this merged with 2.0.0rc4 and make branches from that for continued work. I think with the latest commits this is okay to merge.

@celikbasak
Copy link
Member Author

It would be good to get this merged with 2.0.0rc4 and make branches from that for continued work. I think with the latest commits this is okay to merge.

Thank you Matt! I agree, I also merged the most recent rc4 commits into this branch. I don't think it has any conflicts left with rc4. @tab-cmd could you please have a look at the current status of this PR?

Copy link
Contributor

@tab-cmd tab-cmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to go. A few cleanup items and suggestions that could become tickets / addressed by others. My major concern is about the integration tests. Please ensure they still work for the EEG model!

@tab-cmd tab-cmd merged commit cadaa00 into 2.0.0rc4 Nov 16, 2023
@tab-cmd tab-cmd deleted the multimodal branch November 16, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants