-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multimodal #294
Multimodal #294
Conversation
…aded correctly TODO implement the GazeModel and transfer to offline analysis
…riggers bug fixes.
…on to not apply the starting offset; updated offline_analysis with the new changes and fixed the imports
…ame based on the device spec. Refactored offline_analysis to use the new function for finding the appropriate raw data file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to get this merged with 2.0.0rc4 and make branches from that for continued work. I think with the latest commits this is okay to merge.
Thank you Matt! I agree, I also merged the most recent rc4 commits into this branch. I don't think it has any conflicts left with rc4. @tab-cmd could you please have a look at the current status of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to go. A few cleanup items and suggestions that could become tickets / addressed by others. My major concern is about the integration tests. Please ensure they still work for the EEG model!
Overview
Offline analysis of multimodal fusion & Add visualize eye data method
Ticket
https://www.pivotaltracker.com/story/show/185036543
https://www.pivotaltracker.com/story/show/182667460
Contributions
offline_analysis
to include both EEG and gaze analyses.Test
load_raw_data
in some modules needs to be updated (missing 1 positional argument after the multimodal update).Documentation
Changelog