Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon] drop xml2 for coupling #966

Merged
merged 1 commit into from
Jul 2, 2024
Merged

[Icon] drop xml2 for coupling #966

merged 1 commit into from
Jul 2, 2024

Conversation

jonasjucker
Copy link
Contributor

No description provided.

@jonasjucker jonasjucker changed the title drop xml2 for coupling [Icon] drop xml2 for coupling Jul 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-02 13:25 UTC

@jonasjucker
Copy link
Contributor Author

launch jenkins icon

@jonasjucker jonasjucker linked an issue Jul 2, 2024 that may be closed by this pull request
[Icon] Remove libxml2 as dependency for +coupling variant #728
Closed
@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_extra-config-args=--disable-new_feature,--enable-old_config_arg-spack_spec
🟢dace_icon.-O1-spack_spec
🟢icon_serialization=create-spack_spec

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_extra-config-args=--disable-new_feature,--enable-old_config_arg-spack_spec
🟢dace_icon.-O1-spack_spec
🟢icon_serialization=create-spack_spec
🟢 system test
Test
🟢install_2024_1_nvhpc-icon_@2024.1-1_nvhpc_^libxml2gcc
🟢install_conditional_dependencies-icon_@2024.1-1_nvhpc_+coupling_+rttov_serialization=create_+emvorado_+mpi_gpu=openacc+cuda_^libxml2gcc
🟢install_icon_24_1_gcc-icon_@2024.1-1_gcc

@dominichofer
Copy link
Contributor

This is in accordance with https://github.com/spack/spack/blob/0ca1ee8b91eec07a35b9b9f626945079a2d00bd5/var/spack/repos/builtin/packages/icon/package.py

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_extra-config-args=--disable-new_feature,--enable-old_config_arg-spack_spec
🟢dace_icon.-O1-spack_spec
🟢icon_serialization=create-spack_spec
🟢 system test
Test
🟢daint_cpu_nvhpc
🟢daint_cpu_nvhpc_out_of_source
🟢daint_gpu_nvhpc

@jonasjucker
Copy link
Contributor Author

@dominichofer Can you review?

@jonasjucker jonasjucker requested a review from dominichofer July 2, 2024 12:19
@jonasjucker jonasjucker merged commit f24b678 into main Jul 2, 2024
4 checks passed
@jonasjucker jonasjucker deleted the drop_xml2 branch July 2, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominichofer dominichofer dominichofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icon] Remove libxml2 as dependency for +coupling variant
3 participants
@jonasjucker @jenkins-apn @dominichofer