[icon-ham] Fix filepath to HAMMOZ namelists for out-of-source builds #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stelliom
changed the title
stelliom
changed the title
|
@jonasjucker Can/should I merge it myself? |
|
Thank you for merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix by @dominichofer allows for out-of-source builds for the icon-ham package. The path to the namelists directory was pointing to the respective copy in the build folder (for out-of-source builds), however it should point to the original namelists directory at the icon root. To achieve this we join the absolute path with the
configure_directoryproperty.