Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icon] Bugfix for +art ~coupling. #796

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[icon] Bugfix for +art ~coupling. #796

merged 1 commit into from
Jul 20, 2023

Conversation

dominichofer
Copy link
Contributor

@dominichofer dominichofer commented Jul 19, 2023

Icon depends_on('libfyaml', when='+coupling') but consumed libfyaml also if +art.

@dominichofer dominichofer requested a review from lxavier July 19, 2023 15:02
@dominichofer
Copy link
Contributor Author

launch jenkins icon

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-07-20 08:28 UTC

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_serialization=create_claw=std-spack_spec

@lxavier
Copy link
Contributor

lxavier commented Jul 19, 2023

@jonasjucker FYI : this PR should the PR #727 : we think the libfyaml is only need for +coupling (i.e. yac) but not for +art . With the current spack we are not able to compile with +art without +coupling - this PR should fix that issue

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🟢 system test
Test
🟢Icon-install_2_6_6_gcc
🟢Icon-install_2_6_6_nvhpc
🟢Icon-install_nwp_cpu
🟢Icon-install_nwp_gpu

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🟢 system test
Test
🟢Icon-install_2_6_6_gcc
🟢daint_cpu_cce
🟢daint_cpu_gcc
🟢daint_cpu_nvhpc
🟢daint_cpu_nvhpc_out_of_source
🟢daint_gpu_nvhpc

Copy link
Contributor

@jonasjucker jonasjucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dominichofer dominichofer merged commit 4c8b48a into main Jul 20, 2023
@dominichofer dominichofer deleted the libfyaml branch July 20, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants