Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosmo-eccodes-definitions] Adds 2.25.0.2 #780

Merged
merged 1 commit into from
Jun 29, 2023
Merged

[cosmo-eccodes-definitions] Adds 2.25.0.2 #780

merged 1 commit into from
Jun 29, 2023

Conversation

dominichofer
Copy link
Contributor

@dominichofer dominichofer commented Jun 29, 2023

I didn't add a test for the new version because an other branch is currently modifying the system tests. More tests need to be added systematically later on anyways.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-06-29 13:26 UTC

@dominichofer
Copy link
Contributor Author

launch jenkins cosmo-eccodes-definitions

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢cosmo-eccodes-definitions-spack_info
🟢cosmo-eccodes-definitions-spack_spec
🟢 system test
Test
🟢CosmoEccodesDefinitions-install_version_2_19_0_7

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢cosmo-eccodes-definitions-spack_info
🟢cosmo-eccodes-definitions-spack_spec
🟢 system test
Test
🟢CosmoEccodesDefinitions-install_version_2_19_0_7

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢cosmo-eccodes-definitions-spack_info
🟢cosmo-eccodes-definitions-spack_spec
🟢 system test
Test
🟢CosmoEccodesDefinitions-install_version_2_19_0_7

Copy link
Contributor

@mjaehn mjaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jonasjucker jonasjucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominichofer dominichofer merged commit 296732c into main Jun 29, 2023
@dominichofer dominichofer deleted the eccodes-def branch June 29, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants