Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon] Remove implicit downgrade of opt-level in icon.mk.in #765

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

jonasjucker
Copy link
Contributor

@jonasjucker jonasjucker commented Jun 14, 2023

This PR is a step toward a recipe that does not manipulate files/configs implictitly.

@jonasjucker
Copy link
Contributor Author

launch jenkins icon

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-06-21 08:36 UTC

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_serialization=create_claw=std-spack_spec

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🟢 system test
Test
🟢daint_cpu_gcc
🟢daint_cpu_nvhpc
🟢daint_gpu_nvhpc

@jonasjucker
Copy link
Contributor Author

launch jenkins icon balfrin

@jonasjucker jonasjucker changed the title [Icon] Remove implicit downgrad of opt-level in icon.mk.in [Icon] Remove implicit downgrade of opt-level in icon.mk.in Jun 15, 2023
@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🟢 system test
Test
🟢Icon-install_nwp_cpu
🟢Icon-install_nwp_gpu

Copy link
Contributor

@dominichofer dominichofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasjucker jonasjucker merged commit 97b8f48 into main Jun 21, 2023
@jonasjucker jonasjucker deleted the fcgroup branch June 21, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants